以下代碼隱藏六個嚴重問題,你能全找出來嗎?
OutputStreamWriter out = ...;
Connection conn = ...;
try {
Statement stat = conn.createStatement();
ResultSet rs = stat.executeQuery("select uid, name from user");
while (rs.next()) {
out.println("ID:" + rs.getString("uid") + ",姓名:" + rs.getString("name"));
}
conn.close(); out.close();
} catch (Exception ex) {
ex.printStackTrace();
}
printStackTrace() 不是處理。異常意味著系統異常,必須:處理、重拋、轉換為業務異常、或**不捕獲**讓上層處理。catch (Exception) 等同捕獲幾乎所有錯誤。應分別捕獲 SQLException、IOException,其他讓其拋出。close() 不會執行。必須用 finally 釋放連線、流。try,導致異常來源難以定位。應縮小範圍,針對性捕獲。try {
Statement stat = conn.createStatement();
ResultSet rs = stat.executeQuery("select uid, name from user");
while (rs.next()) {
out.println("ID:" + rs.getString("uid") + ",姓名:" + rs.getString("name"));
}
} catch (SQLException sqlex) {
out.println("警告:資料不完整");
throw new ApplicationException("讀取資料時出現 SQL 錯誤", sqlex);
} catch (IOException ioex) {
throw new ApplicationException("寫入資料時出現 IO 錯誤", ioex);
} finally {
closeQuietly(conn);
closeQuietly(out);
}
// 輔助方法:安全關閉並記錄錯誤
void closeQuietly(AutoCloseable res) {
if (res != null) try { res.close(); }
catch (Exception e) { log.error("關閉資源失敗: " + res, e); }
}
異常處理不是樣板代碼,**每個 catch 都要有明確意圖**。養成「小 try、精確 catch、必有 finally、豐富錯誤上下文」的習慣,才能避開這六大坑。